This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Use webrtc for coder sh #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #15591: |
f0ssel
approved these changes
Aug 3, 2021
|
@deansheather @f0ssel This would likely break any v1 providers. I'm guessing we already released the CLI for the last release so I can merge this yes? |
|
Yup this will be safe for 1.22 |
kylecarbs
suggested changes
Aug 9, 2021
|
@kylecarbs That sort of solves things, but the quoting was also different for the two cases. A more general solution would nice, I didn't try and tackle that here. |
kylecarbs
approved these changes
Aug 9, 2021
johnstcn
pushed a commit
that referenced
this pull request
Sep 9, 2021
- Use webrtc tunnel for `coder sh` command
johnstcn
added a commit
that referenced
this pull request
Sep 10, 2021
* chore: Use webrtc for coder sh (#408) - Use webrtc tunnel for `coder sh` command * chore(cli): "fix" broken unit test Co-authored-by: Steven Masley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Uses webrtc for
coder sh