Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

feat(cli): compare hotfix version metadata #450

Merged
merged 7 commits into from
Oct 8, 2021

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Oct 8, 2021

This PR allows specifying cli.N hotfix versions to download.
Also altered the success message to remove redundant information.

Before:

$ ./coder update --version v1.19.0+cli.1                                                                                                                                                                                                                                                                                                                                                                                 
info: Current version of coder-cli is "v2.34.5"                                                                                                                                                                                                                                                                                                                                                                           
? Do you want to download version 1.19.0 instead? [y/N] y                                                                                                                                                                                                                                                                                                                                                                
info: query github releases                                                                                                                                                                                                                                                                                                                                                                                               
  | url: "https://api.github.com/repos/cdr/coder-cli/releases/tags/v1.19.0"                                                                                                                                                                                                                                                                                                                                               
info: fetching coder-cli from GitHub releases
  | https://github.com/cdr/coder-cli/releases/download/v1.19.0/coder-cli-linux-amd64.tar.gz
info: updated binary reports "coder version v1.19.0 go1.16.4 linux/amd64"
success: Updated coder CLI to version 1.19.0+cli.1

After:

$ ./coder update --version v1.19.0+cli.1
info: Current version of coder-cli is "v2.34.5"
Do you want to download version 1.19.0++cli.1 instead: y
info: query github releases
  | url: "https://api.github.com/repos/cdr/coder-cli/releases/tags/v1.19.0+cli.1"
info: fetching coder-cli from GitHub releases
  | https://github.com/cdr/coder-cli/releases/download/v1.19.0%2Bcli.1/coder-cli-linux-amd64.tar.gz
info: updated binary reports "coder version v1.19.0+cli.1 go1.16.4 linux/amd64"
success: Updated coder CLI

@johnstcn johnstcn self-assigned this Oct 8, 2021
@shortcut-integration
Copy link

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@coveralls
Copy link

coveralls commented Oct 8, 2021

Pull Request Test Coverage Report for Build 1320554222

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of 47 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 48.165%

Files with Coverage Reduction New Missed Lines %
wsnet/dial.go 2 76.78%
Totals Coverage Status
Change from base Build 1313295126: 0.4%
Covered Lines: 2861
Relevant Lines: 5940

💛 - Coveralls

Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat

@johnstcn johnstcn merged commit 64a406e into main Oct 8, 2021
@johnstcn johnstcn deleted the cj/ch17586/compare_cli_metadata branch October 8, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants