fix: reconcile tags when changes occur #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that there is always a tag set when editing a help thread.
This helps to avoid threads where "closed" and "opened" is set, which mostly happens when we mark an answer with AnswerOverflow.
This also makes sure that there is always at least a tag, so that if a tag is removed but none is added afterwards, the tag will be reverted.
This is intentionally slow as I chose to debounce the events to avoid race conditions due to human behavior (e.g 1 event for a tag deletion, then 1 event for a tag add), this will just diff the past thread state to the current one after 1.5s, this avoids looping and other bad behaviors.
I'll implement a integration where AnswerOverflow triggers a thread close whenever the answer is set but this will do for now.
Closes #4