Skip to content

tests(e2e): run tests with multiple permission levels where appropriate #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #163
aslilac opened this issue Oct 28, 2024 · 0 comments · Fixed by coder/coder#15892
Closed
Tracked by #163

tests(e2e): run tests with multiple permission levels where appropriate #168

aslilac opened this issue Oct 28, 2024 · 0 comments · Fixed by coder/coder#15892
Assignees
@aslilac
Labels
tests

Comments

@aslilac
Copy link
Member

aslilac commented Oct 28, 2024 •
edited
Loading

It would add a lot of coverage if we could run e2e tests as users other the an admin. We should be able to run them as user admins, template admins, etc. as appropriate.
@aslilac aslilac mentioned this issue Oct 28, 2024
Closed
6 tasks
@coder-labeler coder-labeler bot added the tests label Oct 28, 2024
@aslilac aslilac changed the title Run these tests with multiple permission levels where appropriate (as a user admin, as a organization user admin, etc.) tests(e2e): run tests with multiple permission levels where appropriate Oct 28, 2024
@aslilac aslilac mentioned this issue Dec 19, 2024
Merged
@aslilac aslilac self-assigned this Dec 19, 2024
aslilac added a commit to coder/coder that referenced this issue Dec 19, 2024
@aslilac
chore: allow signing in as non-admin users in e2e tests (#15892)
962608c 
Closes coder/internal#168

Gets rid of the "global state" authentication, and adds a `login` helper
which should be called at the beginning of each test. This means that
not every test needs to authenticated as admin, and we can even have
tests that encompass multiple permission levels.

We also now create more than just the single admin user during setup, so
that we can have a set of users to pick from as appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: allow signing in as non-admin users in e2e tests coder/coder
1 participant
@aslilac