Skip to content

flake: VPN tests failing on test-go (ubuntu-latest) #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrunoQuaresma opened this issue May 8, 2025 · 1 comment · Fixed by coder/coder#17737
Closed

flake: VPN tests failing on test-go (ubuntu-latest) #624

BrunoQuaresma opened this issue May 8, 2025 · 1 comment · Fixed by coder/coder#17737
Assignees
@ibetitsmike
Labels
flake

Comments

@BrunoQuaresma
Copy link

Failure: https://github.com/coder/coder/actions/runs/14906539299

Mostly all the vpn tests are failing:

=== Failed
=== FAIL: vpn TestTunnel_sendAgentUpdateReconnect (0.00s)
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: wrote out header
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: write ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: handshake read/write complete  their_header="codervpn tunnel 1.1"
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: handshake validated  common_version={"major":1,"minor":1}
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: wrote out header
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: write ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: handshake read/write complete  their_header="codervpn manager 1.1"
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: handshake validated  common_version={"major":1,"minor":1}
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn.serdes: starting sendLoop
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager.serdes: starting recvLoop
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn.serdes: starting recvLoop
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager.serdes: starting sendLoop
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn.serdes: about to read message  length=46
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn.serdes: passed received message to speaker
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: sent rpc request  msg_id=1  req="rpc:{msg_id:1}  start:{tunnel_file_descriptor:2  coder_url:\"[https://coder.example.com\](https://coder.example.com/)"  api_token:\"fakeToken\"}"
    t.go:106: 2025-05-08 12:39:30.079 [info]  tunnel.vpn: starting CoderVPN tunnel  url=https://coder.example.com/  tunnel_fd=2
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: using default networking stack as no custom stack was provided
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: about to read message  length=8
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: passed received message to speaker
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: got response  msg_id=1  resp="rpc:{response_to:1}  start:{success:true}"
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: about to read message  length=124
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: passed received message to speaker
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: about to read message  length=171
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: passed received message to speaker
    tunnel_internal_test.go:576: cannot AdvanceNext because there are no timers or tickers running

=== FAIL: vpn TestRPCVersionIsCompatibleWith/incompatible_major_versions (unknown)

=== FAIL: vpn TestSpeaker_unaryRPC_mainline (unknown)
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: wrote out header
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: wrote out header
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: write ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: write ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: handshake read/write complete  their_header="codervpn manager 1.1"
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tun: handshake validated  common_version={"major":1,"minor":1}
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: handshake read/write complete  their_header="codervpn tunnel 1.1"
    t.go:106: 2025-05-08 12:39:30.078 [debu]  mgr: handshake validated  common_version={"major":1,"minor":1}

=== FAIL: vpn TestRPCVersionParseString/valid_version_with_larger_numbers (unknown)

=== FAIL: vpn TestSpeaker_HandshakeInvalid (unknown)

=== FAIL: vpn TestSpeaker_HandshakeInvalid/unexpected_role (unknown)

=== FAIL: vpn TestTunnel_sendAgentUpdate (unknown)
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  tunnel.vpn: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: got newline header delimiter
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: read ok
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: wrote out header
    t.go:106: 2025-05-08 12:39:30.078 [debu]  manager: write ok
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: handshake read/write complete  their_header="codervpn tunnel 1.1"
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: handshake validated  common_version={"major":1,"minor":1}
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: wrote out header
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: write ok
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: handshake read/write complete  their_header="codervpn manager 1.1"
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: handshake validated  common_version={"major":1,"minor":1}
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn.serdes: starting recvLoop
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn.serdes: starting sendLoop
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: starting recvLoop
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: starting sendLoop
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn.serdes: about to read message  length=46
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn.serdes: passed received message to speaker
    t.go:106: 2025-05-08 12:39:30.079 [info]  tunnel.vpn: starting CoderVPN tunnel  url=https://coder.example.com/  tunnel_fd=2
    t.go:106: 2025-05-08 12:39:30.079 [debu]  tunnel.vpn: using default networking stack as no custom stack was provided
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: about to read message  length=8
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: passed received message to speaker
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: sent rpc request  msg_id=1  req="rpc:{msg_id:1}  start:{tunnel_file_descriptor:2  coder_url:\"[https://coder.example.com\](https://coder.example.com/)"  api_token:\"fakeToken\"}"
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager: got response  msg_id=1  resp="rpc:{response_to:1}  start:{success:true}"
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: about to read message  length=124
    t.go:106: 2025-05-08 12:39:30.079 [debu]  manager.serdes: passed received message to speaker

=== FAIL: vpn TestSpeaker_HandshakeInvalid/preamble (unknown)

=== FAIL: vpn TestSpeaker_HandshakeInvalid/unknown_role (unknown)

=== FAIL: vpn TestConvertRouterConfig/Empty (unknown)

=== FAIL: vpn TestClient_WorkspaceUpdates/empty (unknown)

=== FAIL: vpn TestSpeaker_HandshakeInvalid/newmajors (unknown)

=== FAIL: vpn TestRPCVersionListParseString/empty_string (unknown)

=== FAIL: vpn TestRPCVersionParseString/invalid_minor_version (unknown)

=== FAIL: vpn TestRPCVersionListParseString/duplicate_versions (unknown)

=== FAIL: vpn TestRPCVersionListParseString/duplicate_major_versions (unknown)

=== FAIL: vpn TestConvertRouterConfig/IPv4_and_IPv6_configuration (unknown)

=== FAIL: vpn TestRPCVersionListParseString/out_of_order_versions (unknown)

=== FAIL: vpn TestRPCVersionParseString/empty_string (unknown)

=== FAIL: vpn TestRPCVersionParseString/invalid_major_version (unknown)

=== FAIL: vpn TestProcessFreshState/AgentAdded (unknown)

=== FAIL: vpn TestRPCVersionParseString/one_part (unknown)

=== FAIL: vpn TestRPCVersionParseString/three_parts (unknown)

=== FAIL: vpn TestProcessFreshState/NoChange (unknown)

=== FAIL: vpn TestRPCVersionListValidate/duplicate_versions (unknown)

=== FAIL: vpn TestProcessFreshState/AgentRemovedWorkspaceAlsoRemoved (unknown)

=== FAIL: vpn TestProcessFreshState/InitialAgentsEmpty (unknown)

=== FAIL: vpn TestTunnel_NetworkSettings (unknown)

=== FAIL: vpn TestRPCVersionParseString (unknown)

=== FAIL: vpn TestClient_WorkspaceUpdates/suffix (unknown)

=== FAIL: vpn TestRPCVersionListValidate/empty_list (unknown)

=== FAIL: vpn TestRPCVersionListParseString/single_version (unknown)

=== FAIL: vpn TestRPCVersionListValidate/out_of_order_versions (unknown)

=== FAIL: vpn TestRPCVersionListValidate/duplicate_major_versions (unknown)

=== FAIL: vpn TestRPCVersionParseString/major_version_is_0 (unknown)

=== FAIL: vpn TestProcessFreshState/UpdateEmpty (unknown)

=== FAIL: vpn TestRPCVersionListValidate/valid_list (unknown)

=== FAIL: vpn TestProcessFreshState (unknown)

=== FAIL: vpn TestRPCVersionListValidate (unknown)

=== FAIL: vpn TestConvertDNSConfig/Empty (unknown)

=== FAIL: vpn TestRPCVersionIsCompatibleWith/compatible_minor_versions (unknown)

=== FAIL: vpn TestConvertDNSConfig/Basic (unknown)
fatal error: sync: unlock of unlocked mutex
@spikecurtis
Copy link 

tunnel_internal_test.go:576: cannot AdvanceNext because there are no timers or tickers running

is pretty likely the culprit.

@ibetitsmike ibetitsmike mentioned this issue May 9, 2025
Merged
ibetitsmike added a commit to coder/coder that referenced this issue May 9, 2025
@ibetitsmike
fix: fixed flaking VPN tunnel tests & bump coder/quartz to 0.1.3 (#17737
2696926 
)

Closes: coder/internal#624
EdwardAngert pushed a commit to coder/coder that referenced this issue May 9, 2025
@ibetitsmike @EdwardAngert
fix: fixed flaking VPN tunnel tests & bump coder/quartz to 0.1.3 (#17737
817ec87 
)

Closes: coder/internal#624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibetitsmike ibetitsmike

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed flaking VPN tunnel tests & bump coder/quartz to 0.1.3 coder/coder
4 participants
@BrunoQuaresma @spikecurtis @ethanndickson @ibetitsmike