This repository was archived by the owner on May 15, 2025. It is now read-only.
fix(filebrowser): only require agent_name when not on subdomain #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that agent_name defaults to an empty string, and introduce validation to require it when subdomain is true. This aligns with expected behavior and prevents misconfiguration.
Simplify test cases by removing unnecessary `agent_name` variable entries. Adjust validation condition for clarity.
|
hey @matifali, couldn't we just grab it somehow from the agent id, or pass the full agent object instead of the id? |
matifali
requested review from
code-asher,
kylecarbs,
Parkreiner and
bcpeinhardt
and removed request for
kylecarbs and
code-asher
|
@phorcys420 We do not have any way to get the agent name from the id within Terraform yet. We are using the same approach in https://registry.coder.com/modules/jetbrains-gateway module |
Parkreiner
approved these changes
Sep 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
agent_namedefaults to an empty string, and introducevalidation to require it when
subdomainistrue. This aligns withexpected behavior and prevents misconfiguration.
generated by
aicommit