This repository was archived by the owner on May 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
fix(filebrowser): support custom base_url in case of custom db path #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @yandolfat, do you plan to come back to this PR? I would be happy to complete this if you are not available. Thanks for the PR. |
Hi, if there is nothing to add, you can complete it, thanks :) |
@yandolfat Could you test the updated functionality by setting the source as module "filebrowser" {
source = "git::https://github.com/yandolfat/modules.git//filebrowser?ref=patches/filebrowser"
agent_id = coder_agent.example.id
agent_name = "main"
subdomain = false
} |
Seems to work :) |
matifali
approved these changes
Oct 18, 2024
@@ -18,7 +18,7 @@ if [ "${DB_PATH}" != "filebrowser.db" ]; then | |||
fi | |||
|
|||
# set baseurl to be able to run if sudomain=false; if subdomain=true the SERVER_BASE_PATH value will be "" | |||
filebrowser config set --baseurl "${SERVER_BASE_PATH}" > ${LOG_PATH} 2>&1 | |||
filebrowser config set --baseurl "${SERVER_BASE_PATH}"$${DB_FLAG} > ${LOG_PATH} 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yandolfat Why is this required here if we specify DB_FLAG
while running filebrowser in line 27.?
I think we would need it only once either in config or while running.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #309.