-
Notifications
You must be signed in to change notification settings - Fork 58
feat(jetbrains-gateway): add slug variable #322
Conversation
matifali
commented
Oct 17, 2024
•
edited
Loading
edited
- Update with new slug variable to allow using the module multiple times. Resolves #321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nit: the reordering should probably have been done in a separate PR (but thank you for doing it!) since it isn't related to this change, and complicated the review.
@dannykopping Thank you. I will extract the ordering changes to a separate PR. |
9385288
to
b37f99a
Compare
b37f99a
to
7bb97ae
Compare
@matifali I just saw this on your v1.0.21 release. |
@djarbz The dault should already be the selected IDE> IF you use the module like module "jetbrains_gateway" {
source = "registry.coder.com/modules/jetbrains-gateway/coder"
version = ">= 1.0.0"
agent_id = coder_agent.dev.id
agent_name = "dev"
folder = local.repo_dir
jetbrains_ides = ["GO", "WS"]
default = "GO"
latest = true
} Then GoLand will be the selected IDE when creating the workspace. I did this for a user request to display two buttons on the workspace page, and an easier way to achieve that was to allow the module to be re-used. Unfortunately, that solution did not work because the same |
Ahh, I was referring to this default.
|