-
Notifications
You must be signed in to change notification settings - Fork 58
fix(code-server): set settings
variable type to any
#368
Conversation
@phorcys420 Can you also do it for |
@matifali yes, i will make a separate PR |
variable
type to map(any)
variable
type to map(any)
92c7e18
to
432630c
Compare
variable
type to map(any)
settings
variable type to any
@matifali we cannot set the type to
so, as pointed out by @gjrtimmer in #296, we have to set the type to but the issue with that is that it can introduce some confusion, because a string or number will match this type constraint, except that it won't work. |
@phorcys420 Have you seen: https://developer.hashicorp.com/terraform/language/expressions/type-constraints#dynamic-types-the-any-constraint I think it is fine to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you verified that it now solves the issue?
Hello, |
@9techijcore I am waiting for #369 and we will cut a release. |
v1.0.26 has been pushed. |
Closes #296