This repository was archived by the owner on May 15, 2025. It is now read-only.
fix(dotfiles): handle failures in dotfiles installation #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the dotfiles installation (`coder dotfiles ...`) fails, the script still shows as successful in the Coder UI.
matifali
approved these changes
Jan 24, 2025
|
HI @chazmo03 Thanks for the contribution. Could you please address the failed CI checks? |
|
@matifali can you please take another look? |
phorcys420
suggested changes
Jan 28, 2025
matifali
changed the title
|
@phorcys420 I made the suggested change. Can you please take another look? |
phorcys420
approved these changes
Feb 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dotfiles installation (
coder dotfiles ...) fails, the script still shows as successful in the Coder UI. This should bubble up any errors so that Coder (and the user) are aware that the installation failed.