fix: preserve parameter form state when owner or code changes #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The parameters form was losing user input whenever the
$owner
changed or terraform code was modified. This happened because:Form
component usedwindow.crypto.randomUUID()
as React keys, causing all form elements to unmount/remount on every render$owner
ordebouncedCode
changed, the useEffect would trigger and call$setParameters
, causing a re-renderSolution
key={p.name}
) to prevent unnecessary component remountingKey Changes
createParametersHash()
function to create deterministic signatures for parameters, owner, and codeuseRef
anduseEffect
to track hash changes and reset form only when neededwindow.crypto.randomUUID()
top.name
rbac_roles
propertyTesting