-
Notifications
You must be signed in to change notification settings - Fork 5
chore: update all source URLs for modules to reflect new namespace format #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Lets 🚢 it
@@ -15,7 +15,7 @@ A module that adds Apache Airflow in your Coder template. | |||
```tf | |||
module "airflow" { | |||
count = data.coder_workspace.me.start_count | |||
source = "registry.coder.com/modules/apache-airflow/coder" | |||
source = "registry.coder.com/nataindata/apache-airflow/coder" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The should be coder
. We can update it to nataindata
once a new version is released, but until a release tag in the form release/nataindata/apache-airflow/<some-version>
exists this won't be available under the new namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's mark this a community module. Details in the internal thread.
@@ -14,7 +14,7 @@ Automatically installs [Node.js](https://github.com/nodejs/node) via [nvm](https | |||
```tf | |||
module "nodejs" { | |||
count = data.coder_workspace.me.start_count | |||
source = "registry.coder.com/modules/nodejs/coder" | |||
source = "registry.coder.com/thezoker/nodejs/coder" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, this should be coder
until a new version of the module is actually published with the namespaced release format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do it and push the new versions? This would help us avoid the mix of new and old formats and the drift between what is in the README and the parent directory of the module.
@@ -17,7 +17,7 @@ Customize the preselected parameter value: | |||
```tf | |||
module "exoscale-instance-type" { | |||
count = data.coder_workspace.me.start_count | |||
source = "registry.coder.com/modules/exoscale-instance-type/coder" | |||
source = "registry.coder.com/whizus/exoscale-instance-type/coder" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, need's to wait on a namespaced release. Should just be coder
No issue to link – it's meant to address feedback from the previous README PR
Changes made
source
properties in Terraform import snippets to use the new namespaced Terraform protocol URLsNotes