Use Axios client for EventSource #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
commented
Feb 28, 2025
src/api.ts
Outdated
| @@ -224,6 +280,7 @@ export async function waitForBuild( | |||
| | undefined, | |||
| }, | |||
| followRedirects: true, | |||
| agent: restClient.getAxiosInstance().defaults.httpAgent, | |||
There was a problem hiding this comment.
This fixes a similar issue with the WebSocket request not using TLS settings
aaronlehmann
force-pushed
the
event-source-axios-3
branch
2 times, most recently
from
12a71ee to
56ce33c
Compare
bcpeinhardt
reviewed
Feb 28, 2025
aaronlehmann
force-pushed
the
event-source-axios-3
branch
2 times, most recently
from
5ede407 to
2fe5804
Compare
This allows client TLS certificates to be used for event monitoring. Upgrade to a newer `eventsource` package that supports a custom `fetch` function, and provide a custom `fetch` function which wraps Axios.
aaronlehmann
force-pushed
the
event-source-axios-3
branch
2 times, most recently
from
0fff882 to
7ef954e
Compare
aaronlehmann
force-pushed
the
event-source-axios-3
branch
from
7ef954e to
6db25d4
Compare
bcpeinhardt
approved these changes
Mar 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows client TLS certificates to be used for event monitoring. Upgrade to a newer
eventsourcepackage that supports a customfetchfunction, and provide a customfetchfunction which wraps Axios.