Skip to content

Fix to change column type with PostgreSQL in production #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Nov 3, 2017

#12 (comment)

postgresql (in production) でmigrationを流すとカラムの型変更時に落ちる。

postgresqlの仕様のようで、タイプキャストを明示的に実行してやる必要がある模様。
cf: https://makandracards.com/makandra/18691-postgresql-vs-rails-migration-how-to-change-columns-from-string-to-integer

ということで、migrationファイル内でconnection.adapter_nameをチェックして、postgresqlの時はタイプキャストするように修正しました。

@yasulab
Copy link
Member

yasulab commented Nov 3, 2017

ありがとうございます! これでちょっと試してみますね ;)

@yasulab yasulab merged commit 756c0fe into master Nov 3, 2017
@yasulab yasulab deleted the fix-postgresql-migration branch November 3, 2017 15:55
@yasulab
Copy link
Member

yasulab commented Nov 3, 2017

お、無事に heroku run rails db:migrate に成功したっぽい🤔

heroku run rails db:migrate                                                         master ✓ ±
 ▸    heroku-cli: update available from 6.13.13 to 6.14.36-15f8a25
Running rails db:migrate on ⬢ coderdojo-japan... up, run.4996 (Hobby)
D, [2017-11-04T00:59:15.963992 #4] DEBUG -- :    (0.7ms)  SELECT pg_try_advisory_lock(2721298366456587855)
D, [2017-11-04T00:59:15.979830 #4] DEBUG -- :    (1.2ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
D, [2017-11-04T00:59:15.987609 #4] DEBUG -- :   ActiveRecord::InternalMetadata Load (1.0ms)  SELECT  "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = $1 LIMIT $2  [["key", "environment"], ["LIMIT", 1]]
D, [2017-11-04T00:59:15.995641 #4] DEBUG -- :    (1.0ms)  BEGIN
D, [2017-11-04T00:59:15.997245 #4] DEBUG -- :    (0.5ms)  COMMIT
D, [2017-11-04T00:59:15.998122 #4] DEBUG -- :    (0.7ms)  SELECT pg_advisory_unlock(2721298366456587855)

@yasulab
Copy link
Member

yasulab commented Nov 3, 2017

先ほどコミットした ed35742 は prefecture= が実行できずにデプロイ失敗していて、prefecture= は migrate に成功しないと呼び出せないので、問題なく成功してますね ;)

実際、先ほど追加した CoderDojo 阿倍野も https://coderdojo.jp/ にちゃんと表示されていることも確認できました! PRありがとうございます😸

@nalabjp
Copy link
Member Author

nalabjp commented Nov 3, 2017

おぉ、ご確認ありがとうございます😌

@yasulab yasulab added the 統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants