Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented May 30, 2018

No description provided.

@mr-c mr-c requested a review from tobyhodges May 30, 2018 07:07
psafont
psafont previously approved these changes May 30, 2018
@mr-c mr-c force-pushed the explicit_param_expr_refs branch from f67b45e to aab0f5e Compare May 30, 2018 11:09
Copy link

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it has leaf childs, it looks like ExpressionTool should also be a link in both files

> - From `steps`
> - From [WorkflowStepInput](http://www.commonwl.org/v1.0/Workflow.html#WorkflowStepInput)
> - `valueFrom`
> - From ExpressionTool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; thanks!

@mr-c mr-c merged commit f49dc3e into gh-pages May 30, 2018
@mr-c mr-c deleted the explicit_param_expr_refs branch May 30, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants