Update 14-runtime.md #144
Merged
Update 14-runtime.md #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure I have all of the terminology correct, but I felt a more detailed explanation of what is going on, what is CWL and what is YAML was needed. Feel free to ask me to re-write. |
tobyhodges
previously requested changes
Jul 26, 2019
There was a problem hiding this comment.
Thank you @longr, this is a clear improvement to the section. If you can remove the one instance of "just" that I mentioned*, I think it will be ready to merge.
*bonus points if you change the other use of "just" (line 44) to "only" too 🙂
_episodes/14-runtime.md
Outdated
| ~~~ | ||
| {: .source} | ||
|
|
||
| Before we run this, lets look at each step in a little more detail. The base command `baseCommand: ["sh", "example.sh"]` will execute the command `sh example.sh`. This will just run the file we create in the shell. |
There was a problem hiding this comment.
I recommend to avoid using the word "just" - it can come across as dismissive language. In this case it can be removed i.e. "This will run the file we create in the shell."
Added more of an explanation to the InitialWorkDirRequirement to hopefully improve the clarity.
mr-c
previously approved these changes
Aug 2, 2019
mr-c
approved these changes
Aug 2, 2019
|
Thank you @longr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more of an explanation to the InitialWorkDirRequirement to hopefully improve the clarity.