Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ package.json.lerna_backup
/*.iml
tsconfig.tsbuildinfo
coverage
dist

docs/.vitepress/dist
docs/.vitepress/cache
Expand Down
7 changes: 7 additions & 0 deletions @commitlint/config-pnpm-scopes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,12 @@
"@types/node": "^18.19.17",
"typescript": "^5.2.2"
},
"exports": {
".": {
"import": "./dist/index.js",
"require": "./dist/index.js",
"types": "./dist/index.d.ts"
}
},
"gitHead": "e82f05a737626bb69979d14564f5ff601997f679"
}
15 changes: 7 additions & 8 deletions @commitlint/config-pnpm-scopes/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
{
"extends": "../../tsconfig.shared.json",
"compilerOptions": {
"target": "ES2020",
"module": "CommonJS",
"declaration": true,
"outDir": "dist",
"rootDir": "/",
"strict": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alsmadi99 why remove strict:true?

Copy link
Contributor Author

@alsmadi99 alsmadi99 Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was to just follow standard of other ts modules in @commitlint like the validator module. as at first when i wrote it i just put the default tsconfig i found online.

"esModuleInterop": true
"composite": true,
"rootDir": "./",
"outDir": "./dist"
},
"include": ["/"]
"include": ["*.ts"],
"exclude": ["./dist/**/*"],
"references": [{ "path": "../types" }]
}
1 change: 1 addition & 0 deletions Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ RUN yarn install --frozen-lockfile --network-timeout 100000 && \
# Commit lint CLI packages
npm pack @commitlint/cli && \
npm pack @commitlint/config-validator && \
npm pack @commitlint/config-pnpm-scopes && \
npm pack @commitlint/config-nx-scopes && \
npm pack @commitlint/ensure && \
npm pack @commitlint/execute-rule && \
Expand Down
10 changes: 5 additions & 5 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import typescriptEslint from '@typescript-eslint/eslint-plugin';
import {createTypeScriptImportResolver} from 'eslint-import-resolver-typescript';
import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
import jest from 'eslint-plugin-jest';
import {importX} from 'eslint-plugin-import-x';
import { importX } from 'eslint-plugin-import-x';
import globals from 'globals';
import tsParser from '@typescript-eslint/parser';
import path from 'node:path';
import {fileURLToPath} from 'node:url';
import { fileURLToPath } from 'node:url';
import js from '@eslint/js';
import {FlatCompat} from '@eslint/eslintrc';
import { FlatCompat } from '@eslint/eslintrc';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand All @@ -19,7 +19,7 @@ const compat = new FlatCompat({

export default [
{
ignores: ['**/lib/', '**/coverage/', '**/node_modules/', '**/fixtures/'],
ignores: ['**/lib/', '**/coverage/', '**/node_modules/', '**/fixtures/', '**/dist/'],
},
importX.flatConfigs.typescript,
...compat.extends('eslint:recommended', 'prettier'),
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
{ "path": "@commitlint/travis-cli" },
{ "path": "@commitlint/prompt" },
{ "path": "@commitlint/cz-commitlint" },
{ "path": "@commitlint/config-conventional" }
{ "path": "@commitlint/config-conventional" },
{ "path": "@commitlint/config-pnpm-scopes" }
]
}
Loading