Fix compilation errors with VS2015 #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umennel
force-pushed
the
vs2015_compiler_fixes
branch
from
04c0afd to
ddb372d
Compare
|
LGTM -- in the future typedefs/aliases would make this better to read. For now it's localised and makes sense anyway. |
umennel
added a commit
to umennel/cpp-netlib
that referenced
this pull request
Mar 31, 2018
umennel
added a commit
to umennel/cpp-netlib
that referenced
this pull request
Mar 31, 2018
deanberris
pushed a commit
that referenced
this pull request
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make some changes to get this compiling with VS2015 again. It complained about conversion from const char* to std::array<...>::const_iterator. So I had to add explicit casts. The downside is that the code became a bit ugly now and more difficult to read. Maybe using typedefs for the array and array iterator types would help?