Skip to content

Error with Jan 21, 2017 C++17 bugfix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeoffHadlington opened this issue Jan 23, 2019 · 6 comments
Closed

Error with Jan 21, 2017 C++17 bugfix #7

GeoffHadlington opened this issue Jan 23, 2019 · 6 comments

Comments

@GeoffHadlington
Copy link

The bugfix to allow the use of the std::optional function from c++17 doesn't compile when building with c++17.
There is a hanging paren after the first #endif in optional.hpp, but in addition, the optional struct defines the bracket operator which is not defined on std::optional.
reply.cpp also didn't include the logger.hpp file containing the __CPP_REDIS_LOG macro.
Because of the std namespace override, the uses of the optional struct in the code needed to be replaced with optional_t.
Additionally, enableIf template needs to be added to the C++17 branch in optional.hpp.
Pull request incoming.

@GeoffHadlington
Copy link
Author

#9
I believe this should resolve the problem satisfactorily for both c++17 and c++11

@EHadoux
Copy link

EHadoux commented Jan 24, 2019

Hello, are you planning to merge into master today or later?

@GeoffHadlington
Copy link
Author

GeoffHadlington commented Jan 24, 2019 via email

@EHadoux
Copy link

EHadoux commented Jan 25, 2019

Ahah that's fine don't worry, I'm compiling with your branch in the mean time.

@appkins appkins closed this as completed Mar 1, 2019
@appkins
Copy link

appkins commented Mar 1, 2019

I merged the changes into master. Thanks for the contribution!

@GeoffHadlington
Copy link
Author

GeoffHadlington commented Mar 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants