msg-filter: ignore version-release in kernel scripts and source files #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 10, 2024
... installed in `usr/src/kernels/...+debug/scripts` Related: https://issues.redhat.com/browse/OSH-563 Closes: csutils#171
hanchuntao
reviewed
Apr 11, 2024
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 16, 2024
The original rule was able to translate: `kernel-4.18.0-552.el8/linux-4.18.0-552.el8.x86_64/` -> `kernel-4.18.0-552.el8/` ... but it did not work for z-stream releases, where the paths are unnecessarily inconsistent (`el8_9` on the first level vs. `el8` on the second level): `kernel-4.18.0-513.5.1.el8_9/linux-4.18.0-513.5.1.el8.x86_64/` Related: https://issues.redhat.com/browse/OSH-563 Closes: csutils#171
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Apr 16, 2024
The original rule was able to translate: `kernel-4.18.0-552.el8/linux-4.18.0-552.el8.x86_64/` -> `kernel-4.18.0-552.el8/` ... but it did not work for z-stream releases, where the paths are unnecessarily inconsistent (`el8_9` on the first level vs. `el8` on the second level): `kernel-4.18.0-513.5.1.el8_9/linux-4.18.0-513.5.1.el8.x86_64/` Related: https://issues.redhat.com/browse/OSH-563 Closes: csutils#171
kdudka
changed the title
... installed in `usr/src/kernels/...+debug/scripts` Related: https://issues.redhat.com/browse/OSH-563
... so that we do not need to remove `/` from the matched group afterwards. No change in behavior intended with this commit. Related: https://issues.redhat.com/browse/OSH-563
The original rule was able to translate: `kernel-4.18.0-552.el8/linux-4.18.0-552.el8.x86_64/` -> `kernel-4.18.0-552.el8/` ... but it did not work for z-stream releases, where the paths are unnecessarily inconsistent (`el8_9` on the first level vs. `el8` on the second level): `kernel-4.18.0-513.5.1.el8_9/linux-4.18.0-513.5.1.el8.x86_64/` Related: https://issues.redhat.com/browse/OSH-563 Closes: csutils#171
|
@hanchuntao Unless the changes in this pull request introduce any new problems, let's approve it and merge it as it is. We can discuss possible further improvements separately. |
|
@kdudka ok, we can merge it first, but I still think there exist many scenarios about the file path. |
hanchuntao
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... installed in
usr/src/kernels/...+debug/scriptsRelated: https://issues.redhat.com/browse/OSH-563