hash-util: make the code work with boost-1.86 #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Aug 27, 2024
... to optimize out the extra traversal step to lower the output string. Closes: csutils#200
... where `TEng::digest_type` expands to an array of chars rather than
an array of ints. This caused each byte in the resulting hash string
to be prepended by 3 zero bytes, which was detected by the CI on macOS:
```
--- /Users/runner/work/csdiff/csdiff/tests/csgrep/0036-csgrep-json-stdout.txt 2024-08-26 16:59:02
+++ - 2024-08-26 17:00:30
@@ -4,7 +4,7 @@
"checker": "SHELLCHECK_WARNING",
"language": "shell",
"tool": "shellcheck",
- "hash_v1": "b6311c1fdc52c47d4279cd6650af36e6f8299960",
+ "hash_v1": "000000b6000000310000001c0000001f000000dc00000052000000c40000007d0000004200000079000000cd0000006600000050000000af00000036000000e6000000f8000000290000009900000060",
"key_event_idx": 0,
"events": [
{
```
... to optimize out the extra traversal step to lower the output string. Closes: csutils#200
|
Merging, thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... where
TEng::digest_typeexpands to an array of chars rather than an array of ints. This caused each byte in the resulting hash string to be prepended by 3 zero bytes, which was detected by the CI on macOS:Also use the
hex_loweralgorithm to optimize out the extra traversal step to lower the output string.