csfilter-kfp: fix handling of empty lines in exclude-paths.txt
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
reviewed
Sep 12, 2024
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 12, 2024
... as empty lines Related: https://issues.redhat.com/browse/OSH-755 Closes: csutils#206
kdudka
force-pushed
the
kfp-empty-lines
branch
from
12cf265 to
78d26ba
Compare
lzaoral
approved these changes
Sep 12, 2024
... which prevented empty lines in `exlude-paths.txt` from being skipped. Resolves: https://issues.redhat.com/browse/OSH-755
... as empty lines Related: https://issues.redhat.com/browse/OSH-755 Closes: csutils#206
kdudka
force-pushed
the
kfp-empty-lines
branch
from
78d26ba to
89ee499
Compare
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/OSH-755