Skip to content

Conversation

@kdudka
Copy link
Member

@kdudka kdudka commented Feb 7, 2025

... so that tests with/without the --shell-form option get assigned distinct test names rather than effectively overwriting each other. This one-line change enables additional 11 tests.

Fixes: commit b05206d
Related: #217
Closes: #219

... so that tests with/without the `--shell-form` option get assigned
distinct test names rather than effectively overwriting each other.
This one-line change enables additional 11 tests.

Fixes: commit b05206d
Related: csutils#217
Closes: csutils#219
@kdudka kdudka requested a review from lzaoral February 7, 2025 16:58
@kdudka kdudka self-assigned this Feb 7, 2025
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdudka
Copy link
Member Author

kdudka commented Feb 16, 2025

@jamacku Thanks for review!

@kdudka kdudka closed this in 00c49eb Feb 16, 2025
@kdudka kdudka merged commit 00c49eb into csutils:main Feb 16, 2025
32 checks passed
@kdudka kdudka deleted the tests-fixup branch February 16, 2025 13:29
kdudka pushed a commit to kdudka/csdiff that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants