Skip to content

Replace minimal-json with regular expression #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpkorstanje merged 1 commit into from
Oct 27, 2025
Merged

Replace minimal-json with regular expression #301

mpkorstanje merged 1 commit into from
Oct 27, 2025

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Oct 27, 2025 •
edited
Loading

⚡️ What's your motivation?

We have two reason to replace minimal-json:

  1. Minimal json is no longer maintained.
  2. Minimal json is shaded in, this makes upgrading to Java 17 more complicated.

And while using regular expressions to parse json won't work in general

  • json is not a regular language - pull request events are[1].

Fixes: #292

  1. https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the remove-json-parser branch 3 times, most recently from 2fc67bc to 311a71c Compare October 27, 2025 14:17
@mpkorstanje mpkorstanje marked this pull request as ready for review October 27, 2025 14:18
@mpkorstanje
Replace minimal-json with regular expression
1fc1b35 
We have two reason to replace minimal-json:

1. Minimal json is no longer maintained.
2. Minimal json is shaded in, this makes upgrading to Java 17 more
   complicated.

And while using regular expressions to parse json won't work in general
- json is not a regular language - pull request events are[1].

Fixes: #292

1. https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request
@mpkorstanje mpkorstanje merged commit 45917b0 into main Oct 27, 2025
4 checks passed
@mpkorstanje mpkorstanje deleted the remove-json-parser branch October 27, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

java: minimal-json is no longer maintained

1 participant

@mpkorstanje