Enable subtitle delay/offset for external SRT in ExoPlayer#1547
Draft
damontecres wants to merge 2 commits into
Draft
Enable subtitle delay/offset for external SRT in ExoPlayer#1547damontecres wants to merge 2 commits into
damontecres wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is still a work-in-progress!
Description
Set subtitle offset for external SRT when playing via ExoPlayer. This should cover the majority of cases that need subtitle adjustments in ExoPlayer since 1) embedded subtitles usually don't need adjustments and 2) most third-party services (ie OpenSubtitles) provide SRT subtitles.
Note: if playing with MPV, you can already set a subtitle offset on any format of subtitles!
TODO
Related issues
Related to #12
Testing
Just the basic with the emulator so far
Screenshots
N/A
AI or LLM usage
None