Skip to content

Bug in contrib/geoToolbox.lua - use of for _,image in ipairs(sel_images) do conflicts with function _(msgid) #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fjb2020 opened this issue Mar 15, 2025 · 2 comments
Labels

Comments

@fjb2020
Copy link
Contributor

fjb2020 commented Mar 15, 2025

I wanted to use the contrib/geoToolbox script to tweak some GPS settings on some images, but it wasn't working.

Inspecting via ./darktable -d lua showed this error
11.0105 LUA ERROR : /Volumes/EXT-Data/Data/darktable/lua/contrib/geoToolbox.lua:310: attempt to call a number value (local '_')

It seems that the use of

for _,image in ipairs(sel_images) do 

causes a conflict with the function _(msgid)

I changed the 8 instances of

for _,image in ipairs(sel_images) do 

to

for jj,image in ipairs(sel_images) do

This fixed the error I was seeing and let me use the script as required.

System: 5.1.0+473~g51e22e438a (nightly) on macOS Sequoia 15.3.2 on M1 Max Studio

@wpferguson
Copy link
Member

If you want to do a PR to fix it that would be fine, otherwise I can do it.

@wpferguson wpferguson added the bug label Mar 15, 2025
fjb2020 added a commit to fjb2020/lua-scripts that referenced this issue Mar 19, 2025
wpferguson added a commit that referenced this issue Mar 19, 2025
Fix issue #571, use of for _,image in ipairs(sel_images) do conflicts with function _(msgid)
@wpferguson
Copy link
Member

Fixed by #576.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants