Add CollectHelper #162
Merged
Add CollectHelper #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworded the button text to better match with the rest of darktable's buttons
supertobi
reviewed
Feb 14, 2019
wpferguson
reviewed
Feb 14, 2019
|
@BzKevin I was thinking of writing a compare function similar to lightoom's using the collect filter to do it. I figured that I was going to have to play with collect to figure out how it worked, but you did it for me. Thanks |
|
@wpferguson Awesome, if it is similar enough in content then maybe adding it in to this same script makes sense? Certainly it wouldn't be hard to duplicate the functionality I've already implemented for the other collect parameters, like filmstrips, day, place, etc. But if you're thinking of making a module with checkboxes for each parameter and then filtering on the selected properties with the selected image's value that my be better served in a new script. Which would be an awesome script by the way. |
Updated variable definitions with 'local' designation. Doing so slightly broke the script so I modified the function calls a tad to pass variables in and out as needed for "CollectOnAll" function to work.
wpferguson
reviewed
Feb 21, 2019
Add translate-ability. Also adds a check that the selected image has an active color label and displays a message if it does not
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plugin CollectHelper which gives the user a few helpful buttons to change collections based on selected image.