Skip to content

video_ffmpeg add df.sanitize_filename() #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2019

Conversation

supertobi
Copy link
Contributor

I'm not 100% sure, but I think we need the df.sanitize_filename() here.

I'm not 100% sure, but I think we need the df.sanitize_filename() here.
@supertobi
Copy link
Contributor Author

@wpferguson and @BzKevin could you please review this pr?

@theres
Copy link
Contributor

theres commented Feb 27, 2019

yes, we need this

@wpferguson
Copy link
Member

@supertobi could you add df.sanitize_filename() to the df.mkdir() and df.rmdir() arguments also? I'll clean up the library elements to make them consistent with the other library functions.

viedeo_ffmpeg df.sanitize_filename() for mkdir and rmdir
@supertobi
Copy link
Contributor Author

please review

I forgot the argument
@supertobi supertobi merged commit 69b9a1f into master Feb 28, 2019
@supertobi supertobi deleted the supertobi-patch-video_ffmpeg branch April 16, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants