Add AutoGrouper #178
Add AutoGrouper #178
Conversation
Adds AutoGrouper script which allows the user to select multiple images (or an entire collection) and automatically group them based on timestamp. The separation between groups is user defined via a slider.
Added comments throughout Change the gap comparison to be inclusive ( from '<' to '<=')
contrib/AutoGrouper.lua
Outdated
| label = _('group gap [sec.]'), | ||
| tooltip = _('minimum gap, in seconds, between groups'), | ||
| soft_min = 1, | ||
| soft_max = 30, |
There was a problem hiding this comment.
Is this high enough? Should it maybe be a minute or two, or five? I tried it on a baseball game I shot and I ended up at 200 seconds. I tried 300, but that was a little too much. I also tried a 2 basketball games shot back to back. With a 30 second gap I got 45 groups. I think the right gap for that is probably 60 seconds, which would group between timeouts. Lastly I tried a senior picture session I did. The 30 second grouping was just about right and the grouping was pretty close to what I did manually when I processed them.
There was a problem hiding this comment.
The hard max is 3600 so the user can enter up to a full 1hr gap. I don't really know what would make a good soft max.
My only thought was to avoid a frustration I have with some other sliders where the adjustments I am trying to make are difficult due to being stuck on the far end of the slider range. This happens to me frequently when using the right-click method for adjusting white balance, It's hard to make fine tune adjustments when lowering WB because I'm already so close to the left-hand boundary.
That being said, I don't have a strong preference here, so if you all feel a higher soft max would be more usable by the majority of people then let's make it whatever you think is best.
There was a problem hiding this comment.
I'm not sure either. I toyed with the idea of 3 sliders, hours, minutes, and seconds, but I'm not sure that's any better. How about we make it 60 seconds, and then see if the users provide any feedback. Or, we can leave it as is and see if the user's have feedback. Up to you. Let me know.
There was a problem hiding this comment.
60 sounds good, a nice even 1 minute. I'll do that and take care of these other notes you've made when I get some time to tinker with these again. Glad you got some use out of it though.
There was a problem hiding this comment.
I made it 60, I also increased the hard max all the way up to a full day. I saw no drawbacks to having a very large hard max.
1) mod changed to MOD
2) autogroup changed to autogrouper
3) prints "please select at least 2 images" if user attempts to run with fewer than 2 images selected
4) change visible module name to "auto group" (lower case)
5) changed soft max on slider to 60s
- I also increase the hard max up to a full day, I saw no reason not to
Adds AutoGrouper script which allows the user to select multiple images (or an entire collection) and automatically group them based on timestamp. The separation between groups is user defined via a slider.