Skip to content

README: list various third-party projects #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2019
Merged

README: list various third-party projects #193

merged 1 commit into from
Nov 10, 2019

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Oct 9, 2019

No description provided.

@supertobi
Copy link
Contributor

@BzKevin
Are this two lines still different from the version here?

wpferguson
wpferguson requested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@wpferguson wpferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could replace wpferguson/Nik_Collection with wpferguson/extra-dt-lua-scripts. The latter isn't populated with anything yet, but there are scripts that were rejected for the repository that I will put in there.

README.md Outdated

* [trougnouf/dtMediaWiki](https://github.com/trougnouf/dtMediaWiki) – Wikimedia Commons export
* [wpferguson/Nik_Collection](https://github.com/wpferguson/Nik_Collection) – Nik_Collection
* [BzKevin/HDRMerge-dt-Plugin](https://github.com/BzKevin/HDRMerge-dt-Plugin) – HDRMerge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already merged into the repository

README.md Outdated
* [Sitwon/dt_fujifilm_ratings](https://github.com/Sitwon/dt_fujifilm_ratings) – Fujifilm Ratings import
* [progo/leica-q-autocrop](https://github.com/progo/leica-q-autocrop) – crop in 35 mm or 50 mm equivalent
* [BzKevin/OpenInPS-Darktable-PlugIn](https://github.com/BzKevin/OpenInPS-Darktable-PlugIn) – open in Adobe Photoshop
* [BzKevin/OpenInExplorer-darktable-plugin](https://github.com/BzKevin/OpenInExplorer-darktable-plugin) – open in file explorer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already merged into the repository

@wpferguson
Copy link
Member

A couple of thoughts.

  1. Is this the right place for this? I can't think of another place that keeps track of lua scripts for darktable, so maybe it is. The only other place I could think of would be pixls.us, but it would probably get lost in all the messages.

  2. Do we need a disclaimer statement saying that this is provided for information only, we haven't tested them, we aren't blessing them (in light of the OpenInPS script), use at your own risk, YMMV?

@supertobi
Copy link
Contributor

@wpferguson

  1. Yes, I think it's the right place.
  2. Yes, I think we need a disclaimer.

@simon04
Please update your patch with the changes @wpferguson suggested.

@simon04
Copy link
Contributor Author

simon04 commented Nov 4, 2019

(Sorry for the long delay – I was travelling.)

@wpferguson, @supertobi, thanks for your review. I amended my commit with your comments and included a disclaimer line.

@wpferguson wpferguson merged commit 7c7118d into darktable-org:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpferguson wpferguson wpferguson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon04 @supertobi @wpferguson