add harmonic armature guide #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on guide I made here: https://discuss.pixls.us/t/add-custom-guides/26288/10?u=johnny-bit
It's actually harmonic armature guide and not dynamic symmetry guide.
How to use harmonic armature: https://www.thomaskegler.com/files/documents/compostion.pdf
additionally this essentially fixes darktable-org/darktable#3139 since adding new guides via lua is good way.
@wpferguson - one question: i commented out the unnecessary middle lines (harmonic armature doesn't use middle lines), but i've seen places where they select and create additional lines. In normal c-coded darktable guides, the widgets allow for options but i have no idea how to add those in lua. I'd love to have this merged as-is and add options later if ever.