Skip to content

Fix issue #571, use of for _,image in ipairs(sel_images) do conflicts with function _(msgid) #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix issue #571, use of for _,image in ipairs(sel_images) do conflicts with function _(msgid) #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions contrib/geoToolbox.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ local function get_first_coordinate()
first_elevation = ''
first_image_date = 0

for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if not image then
first_have_data = false
else
Expand Down Expand Up @@ -206,7 +206,7 @@ local function get_second_coordinate()
second_elevation = ''
second_image_date = 0

for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if not image then
second_have_data = false
else
Expand Down Expand Up @@ -242,7 +242,7 @@ local calc_in_between_slider = dt.new_widget("slider")
--ToDo: this needs more love
local function calc_in_between()
local sel_images = dt.gui.action_images
for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if image then
image_date = make_time_stamp(image.exif_datetime_taken)
if (first_have_data and second_have_data) then
Expand Down Expand Up @@ -289,7 +289,7 @@ local function copy_gps()
copy_gps_longitude = ''
copy_gps_elevation = ''

for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if not image then
copy_gps_have_data = false
else
Expand All @@ -316,7 +316,7 @@ end
local function paste_gps(image)
local sel_images = dt.gui.action_images

for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if (label_copy_gps_lat.value) then
image.latitude = copy_gps_latitude
end
Expand All @@ -343,7 +343,7 @@ local function open_location_in_gnome_maps()
local i = 0;

-- Use the first image with geo information
for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if ((image.longitude and image.latitude) and
(image.longitude ~= 0 and image.latitude ~= 90) -- Sometimes the north-pole but most likely just wrong data
) then
Expand Down Expand Up @@ -386,7 +386,7 @@ local function reverse_geocode()
local i = 0;

-- Use the first image with geo information
for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if ((image.longitude and image.latitude) and
(image.longitude ~= 0 and image.latitude ~= 90) -- Sometimes the north-pole but most likely just wrong data
) then
Expand Down Expand Up @@ -461,7 +461,7 @@ local function calc_distance()

local sel_images = dt.gui.selection()

for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if ((image.longitude and image.latitude) and
(image.longitude ~= 0 and image.latitude ~= 90) -- Sometimes the north-pole but most likely just wrong data
) then
Expand Down Expand Up @@ -545,7 +545,7 @@ local function altitude_profile()
local elevationAdd = 0;

local sel_images = dt.gui.action_images
for _,image in ipairs(sel_images) do
for jj,image in ipairs(sel_images) do
if ((not isnan(image.longitude) and not isnan(image.latitude) and not isnan(image.elevation) and image.elevation) and
(image.longitude ~= 0 and image.latitude ~= 90) -- Sometimes the north-pole but most likely just wrong data
) then
Expand Down