Align sequence tooltip with code. #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the tooltip is correct as is and the code is backwards. It should be
This matches the darktable variables tooltip here, https://docs.darktable.org/usermanual/4.8/en/special-topics/variables/ |
|
Oh, I didn't notice that, I can update the PR if you want. |
This reverts commit c6eee15.
|
@wpferguson let me know what you think. |
|
If you want to update the PR that would be great. Thanks |
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the tooltip is not aligned with the code.
Based on this we expect the start number first and the width second. I didn't change the string match pattern, it's not clear to me if we want it the other way around of not.