Selection of untagged images #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automatic tags added by darktable are also considered untagged
supertobi
reviewed
Sep 14, 2017
contrib/select_untagged.lua
Outdated
| ]] | ||
|
|
||
| local dt = require "darktable" | ||
| require "official/yield" |
There was a problem hiding this comment.
I think this "require" is not needed in this script.
supertobi
reviewed
Sep 14, 2017
| dt.configuration.check_version(...,{3,0,0},{4,0,0},{5,0,0}) | ||
|
|
||
| -- Tell gettext where to find the .mo file translating messages for a particular domain | ||
| gettext.bindtextdomain("select_untagged",dt.configuration.config_dir.."/lua/locale/") |
There was a problem hiding this comment.
Do you have any translations, that you could add to the pr?
There was a problem hiding this comment.
Not yet, but I will add german and french translations.
There was a problem hiding this comment.
Should I include the .mo file, or is it left to the user of the script to build it?
There was a problem hiding this comment.
As we don't have a build system for the mo file I would add them.
There was a problem hiding this comment.
I have added them to my branch.
There was a problem hiding this comment.
then please make a new pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tagging my collection, I was looking for a way to find untagged images in darktable. All I found were older threads and a feature request from five years ago.
So I wrote a lua script which checks the collection for untagged images and adds them to the selection. Images having no tags at all or only tags added by darktable (e.g. darktable|format|cr2) are considered untagged.
Maybe this is interesting for some other users, or did I miss an official way to show untagged images?