This repository was archived by the owner on May 17, 2024. It is now read-only.
feat: support TOP operator #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pik94
force-pushed
the
support-top-operator
branch
from
fd0888a to
94b6d93
Compare
|
offset_limit() must not be enough? ex: https://github.com/datafold/data-diff/blob/master/data_diff/databases/mssql.py#L113C9-L113C21 |
dlawin
approved these changes
Oct 31, 2023
nolar
suggested changes
Nov 1, 2023
Merged
pik94
force-pushed
the
support-top-operator
branch
from
8b7484a to
4673b73
Compare
pik94
force-pushed
the
support-top-operator
branch
from
4673b73 to
0bd24a3
Compare
dlawin
approved these changes
Nov 13, 2023
nolar
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some databases does not support
LIMIToperator but hasTOP. This PR adds supporting ofTOP. A flagUSE_TOP_INSTEAD_LIMITcontrols which op should be used for a specific database.