Make compatible with <1.0 and >1.0a

[simonw]

Refs:

• Make compatible with pre and post 1.0 #15

[simonw]

Bit of a gross hack here to get the internal database working in tests.

[simonw]

Using this new feature in datasette-test:

• permissions= argument for patching over permission differences between 1.0 and <1.0 datasette-test#4

[simonw]

Using this new feature in datasette-test:

• datasette_test.actor_cookie() function datasette-test#5

[simonw]

To compensate for datasette.actors_from_ids() not being in Datasette <1.0

[simonw]

Permission tests are failing for the 1.0a version:

=========================== short test summary info ============================
FAILED tests/test_secrets.py::test_permissions[admin-/-/secrets-GET-None] - assert 403 != 403
 +  where 403 = <Response [403 Forbidden]>.status_code
FAILED tests/test_secrets.py::test_permissions[admin-/-/secrets/EXAMPLE_SECRET-GET-None] - assert 403 != 403
 +  where 403 = <Response [403 Forbidden]>.status_code
FAILED tests/test_secrets.py::test_set_secret - assert 403 == 302
 +  where 403 = <Response [403 Forbidden]>.status_code
FAILED tests/test_secrets.py::test_get_secret - assert 403 == 302
 +  where 403 = <Response [403 Forbidden]>.status_code
FAILED tests/test_secrets.py::test_secret_index_page - assert 403 == 200
 +  where 403 = <Response [403 Forbidden]>.status_code
=================== 5 failed, 6 passed, 20 warnings in 0.90s ===================

[simonw]

In the debugger for pytest --pdb -x:

(Pdb) from pprint import pprint
(Pdb) pprint(ds._permission_checks)
deque([{'action': 'manage-secrets',
        'actor': {'id': 'root'},
        'resource': None,
        'result': False,
        'used_default': False,
        'when': '2024-04-26T23:02:15.359701'},
       {'action': 'view-instance',
        'actor': {'id': 'root'},
        'resource': None,
        'result': True,
        'used_default': True,
        'when': '2024-04-26T23:02:15.366520'},
       {'action': 'debug-menu',
        'actor': {'id': 'root'},
        'resource': None,
        'result': True,
        'used_default': False,
        'when': '2024-04-26T23:02:15.366554'},
       {'action': 'manage-secrets',
        'actor': {'id': 'root'},
        'resource': None,
        'result': False,
        'used_default': False,
        'when': '2024-04-26T23:02:15.366567'}],
      maxlen=200)

[simonw]

Why did this check fail?

       {'action': 'manage-secrets',
        'actor': {'id': 'root'},

Here's why:

(Pdb) ds.config
{'plugins': {'datasette-secrets': {...}}, 'permissions': {'manage-secrets': {'id': 'admin'}}}

That's configured to allow admin, not root.

[simonw]

Bug is in datasette-test: https://github.com/datasette/datasette-test/blob/58a83686aac95071afaf77ec6a4cd4da7d16eb92/datasette_test/__init__.py#L55-L59

• actor_cookie() hard-codes root datasette-test#7