Krew manifest update #294
Merged
Krew manifest update #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Owner
|
@mstoops ;( Looks like this is still a dud ;( I don't think I've ever seen this gha working. |
Contributor
Author
|
Well that is frustrating! It's interesting that in the Action failures, it has a link that 404s. If you click on it, it's a link with a ':' on the end. If you strip the colon, then the file found. Could be a red herring, but still strange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might fix your Krew action. Your original .krew.yaml didn't work when run through the krew-release-bot Docker container (see https://github.com/rajatjindal/krew-release-bot?tab=readme-ov-file#testing-the-template-file). The updated .krew.yaml does, you can try using:
docker run -v $PWD/.krew.yaml:/tmp/template-file.yaml ghcr.io/rajatjindal/krew-release-bot:v0.0.46 krew-release-bot template --tag v0.20.5 --template-file /tmp/template-file.yaml