Skip to content

Conversation

@NicoVIII
Copy link
Contributor

Like discussed here, the pnpm feature was moved into devcontainers-contrib:
https://github.com/devcontainers-contrib/features/issues/265

The old entry can be removed from the index to avoid the duplicate listing of pnpm. The one in devcontainers-contrib should be used from now on.

Like discussed here, pnpm was moved into devcontainers-contrib:
https://github.com/devcontainers-contrib/features/issues/265

The old repository can be removed from the index to avoid the duplicate listing of pnpm. The one in devcontainers-contrib should be used from now on.
@eitsupi
Copy link
Contributor

eitsupi commented Jan 25, 2023

The old entry can be removed from the index to avoid the duplicate listing of pnpm. The one in devcontainers-contrib should be used from now on.

@NicoVIII Did you check the process how to deprecate Features?
https://github.com/devcontainers/spec/blob/cd07f1584acd44ca84c7841fdc5548754c78f381/proposals/features-legacyIds-deprecated-properties.md

This procedure can be used to notify users that a Feature has been deprecated.

@NicoVIII
Copy link
Contributor Author

Not yet, I first wanted to make sure nobody chooses it in the creation dialog from now on.

Thanks for the link, I will check it out shortly :)

@samruddhikhandale
Copy link
Member

Thanks @eitsupi for pointing to the doc.

@NicoVIII If you deprecate the Feature, then it will stop getting listed by the supporting tools. Also, it will update the README and in future we will be adding VS Code hints to notify the user.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you only have a single Feature, removing it from the index definitely works for you. However, if you had multiple Features in the same repo then using the deprecated flag was a better approach.

@samruddhikhandale samruddhikhandale merged commit 233fd92 into devcontainers:gh-pages Jan 25, 2023
@NicoVIII NicoVIII deleted the patch-1 branch January 25, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants