Skip to content

Conversation

@akhildevelops
Copy link
Contributor

Android SDK Tools and APT packages Installer

@akhildevelops akhildevelops requested a review from a team as a code owner February 15, 2023 14:50
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you help fix the merge conflict?

@eitsupi
Copy link
Contributor

eitsupi commented Feb 16, 2023

APT packages

Hi @akhildevelops, I just wanted to make sure you knew that a Feature similar to this already exists.
https://github.com/rocker-org/devcontainer-features/tree/main/src/apt-packages

If it is a Feature with similar functionality but different purpose, it may be worth documenting.

@akhildevelops
Copy link
Contributor Author

I haven't come across it. My feature also serves the same purpose.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@samruddhikhandale samruddhikhandale merged commit c335352 into devcontainers:gh-pages Feb 16, 2023
@akhildevelops akhildevelops deleted the patch-1 branch February 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants