Skip to content

Conversation

@ronakj
Copy link
Contributor

@ronakj ronakj commented Sep 6, 2023

x is confusing in the supported fields entries because someone can assume that it means not supported.
is much less confusing.

Reference discussion devcontainers/spec#284

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bamurtaugh
Copy link
Member

@samruddhikhandale tagging you for review here as well just to get another set of eyes before I merge 😄

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale samruddhikhandale merged commit a7ece85 into devcontainers:gh-pages Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants