Skip to content

Conversation

@tonynajjar
Copy link
Contributor

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Description

Adds ROS2 devcontainer template

@tonynajjar tonynajjar requested a review from a team as a code owner June 2, 2024 12:11
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale
Copy link
Member

@tonynajjar Can you help resolve the merge conflicts, then we are good to merge? thanks!

@tonynajjar
Copy link
Contributor Author

@samruddhikhandale done

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samruddhikhandale samruddhikhandale merged commit 0d81e4d into devcontainers:gh-pages Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants