BDD engine: transform SVA to LTL, then LTL to CTL #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BDD engine now transforms SVA to LTL, when possible, which in turn is transformed to CTL, when possible. This is strictly more general than the current direct mapping.
tautschnig
reviewed
May 8, 2025
| @@ -1,13 +1,13 @@ | |||
| module main(input clk); | |||
|
|
|||
| reg [31:0] x = 0; | |||
| reg [7:0] x = 0; | |||
There was a problem hiding this comment.
Why do the changes to property transforms entail this change? AFAIK this test was passing before.
There was a problem hiding this comment.
They now do run with BDDs, and the BDDs simply don't scale to 32 bits. They can do 8.
There was a problem hiding this comment.
But then how did this test pass before?
There was a problem hiding this comment.
We did SAT-based BMC only. That can do 32 bits.
tautschnig
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BDD engine now transforms SVA to LTL, when possible, which in turn is transformed to CTL, when possible.
This is strictly more general than the current direct mapping.