Fix nav highlight #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent position/height.
…xt's magic navigation.
Deploying gitfromscratch with
|
| Latest commit: |
fcf3ebf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01f29e2f.gitfromscratch.pages.dev |
| Branch Preview URL: | https://fix-nav-highlight.gitfromscratch.pages.dev |
|
Suggestion:
|
… they would probably still work in static builds).
…ections the highlight behaves weirdly. This makes it behave a bit better, but still not great.
…st style a normal div.
|
This is ok, but still behaves less-than-ideal in certain situations. It's a tricky problem to solve. Happy to chat about it if you want. |
Closed
nedtwigg
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nav highlight works pretty well, but it still has some edge cases that need to be worked out. Also need to fix the green highlight on the left-side for the group root pages.