Skip to content

Fix: Add remoteAuthS3 type to DiscussionEmbedConfig Interface #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisjtang merged 6 commits into from
Jul 7, 2025
Merged

Fix: Add remoteAuthS3 type to DiscussionEmbedConfig Interface #159

chrisjtang merged 6 commits into from
Jul 7, 2025
+25 −9

Conversation

@chrisjtang
Copy link
Contributor

@chrisjtang chrisjtang commented Jun 30, 2025 •
edited
Loading

Description

These changes add the remoteAuthS3 type to the DiscussionEmbedConfig interface.

Motivation and Context

#151

How Has This Been Tested?

Using https://github.com/chrisjtang/foodandstuff/tree/typescript, the original bug was reproduced and fixed with the change in this PR.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • All new and existing tests passed.

@chrisjtang chrisjtang self-assigned this Jun 30, 2025
@chrisjtang chrisjtang requested review from Hovspian and tail July 1, 2025 19:38
Hovspian
Hovspian reviewed Jul 3, 2025
View reviewed changes
Hovspian
Hovspian approved these changes Jul 3, 2025
View reviewed changes
Copy link

@Hovspian Hovspian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrisjtang chrisjtang merged commit 99dc890 into master Jul 7, 2025
3 checks passed
@chrisjtang chrisjtang deleted the sso-type branch July 7, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hovspian Hovspian Hovspian approved these changes

@tail tail Awaiting requested review from tail

Assignees

@chrisjtang chrisjtang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisjtang @Hovspian