-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
Adapt to scikit-learn 1.6 estimator tag changes #11021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trivialfis
merged 15 commits into
dmlc:master
from
jameslamb:python/support-scikit-learn-1.6
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
79ed32c
add methods in XGBModel
jameslamb 3106cf1
implement __sklearn_tags__()
jameslamb 3af44be
regressor tests passing
jameslamb a9e30b4
Merge branch 'master' of github.com:dmlc/xgboost into python/support-…
jameslamb 6a12576
centrallize more in _more_tags(), ignore testing outputs in .gitignore
jameslamb 52e6d83
make get_params() check less fragile
jameslamb 816667a
formatting
jameslamb abfc6a6
ignore pylint warning
jameslamb ef725c1
fix imports in environment without scikit-learn, fix tests
jameslamb d845922
address pylint warnings
jameslamb b7564a1
remove 'pylint: disable' comments for too-many-ancestors and too-few-…
jameslamb 8364e92
Merge branch 'master' into python/support-scikit-learn-1.6
jameslamb a511848
rely on mixins to set estimator_type, removed unused imports
jameslamb 27a1bcc
Merge branch 'master' into python/support-scikit-learn-1.6
jameslamb 18c602f
check for get_params() instead
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
implement __sklearn_tags__()
- Loading branch information
commit 3106cf10e8ef9668c36fbdf4bd7c0d54270c5a80
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this if we inherit the classifier mixin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you are totally right, I don't think we do:
https://github.com/scikit-learn/scikit-learn/blob/e6037ba412ed889a888a60bd6c022990f2669507/sklearn/base.py#L536-L544
Removed this, the corresponding
LGBRegressor
code, and the imports ofClassifierTags
/RegressorTags
in a511848