Specify protocol for client during init #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents custom config from breaking init if protocol setting has been changed * Moved default settings from /etc/mysql/conf.d/docker.cnf to /etc/mysql/my.cnf for 5.5-image Prevents suggested method for custom config removing default config
|
LGTM 👍 |
tianon
added a commit
that referenced
this pull request
Jul 6, 2015
Specify protocol for client during init
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 6, 2015
- `haproxy`: 1.5.14 - `mysql`: add `--protocol` during init (docker-library/mysql#84) - `tomcat`: 7.0.63
This was referenced Jul 6, 2015
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `haproxy`: 1.5.14 - `mysql`: add `--protocol` during init (docker-library/mysql#84) - `tomcat`: 7.0.63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image init can fail if user specifies a custom config with a changed socket setting (e.g. setting it to tcp) as mentioned in issue #83.
There's also a related problem in that the 5.5 image stores the default settings in a folder that will be overriden by the suggested method for providing a custom config (https://github.com/docker-library/docs/tree/master/mysql#user-content-using-a-custom-mysql-configuration-file).
Fixes #83