Skip to content

Include BUILDKIT_SYNTAX in the list of built-in ARGs #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Include BUILDKIT_SYNTAX in the list of built-in ARGs #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to the Docker Language Server will be documented in this fil

## [Unreleased]

### Added

- Dockerfile
- textDocument/hover
- support configuring vulnerability hovers with an experimental setting ([#192](https://github.com/docker/docker-language-server/issues/192))
Expand All @@ -17,6 +19,12 @@ All notable changes to the Docker Language Server will be documented in this fil
- textDocument/publishDiagnostics
- support filtering vulnerability diagnostics with an experimental setting ([#192](https://github.com/docker/docker-language-server/issues/192))

### Fixed

- Bake
- textDocument/publishDiagnostics
- stop flagging `BUILDKIT_SYNTAX` as an unrecognized `ARG` ([#187](https://github.com/docker/docker-language-server/issues/187))

## [0.7.0] - 2025-05-09

### Added
Expand Down
1 change: 1 addition & 0 deletions internal/bake/hcl/diagnosticsCollector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ var builtinArgs = []string{
"BUILDKIT_CACHE_MOUNT_NS",
"BUILDKIT_MULTI_PLATFORM",
"BUILDKIT_SANDBOX_HOSTNAME",
"BUILDKIT_SYNTAX",
"BUILDKIT_DOCKERFILE_CHECK",
"BUILDKIT_CONTEXT_KEEP_GIT_DIR",
"SOURCE_DATE_EPOCH",
Expand Down
2 changes: 1 addition & 1 deletion internal/bake/hcl/diagnosticsCollector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func TestCollectDiagnostics(t *testing.T) {
},
{
name: "args references built-in args",
content: "target \"t1\" {\n args = {\n HTTP_PROXY = \"\"\n HTTPS_PROXY = \"\"\n FTP_PROXY = \"\"\n NO_PROXY = \"\"\n ALL_PROXY = \"\"\n }\n}",
content: "target \"t1\" {\n args = {\n HTTP_PROXY = \"\"\n HTTPS_PROXY = \"\"\n FTP_PROXY = \"\"\n NO_PROXY = \"\"\n ALL_PROXY = \"\"\n BUILDKIT_SYNTAX = \"\"\n }\n}",
diagnostics: []protocol.Diagnostic{},
},
{
Expand Down
Loading