fix the background color of the sidebar on 'medium' sized devices #11381
Conversation
|
Deploy preview for docsdocker ready! Built with commit 3961a25 |
|
Thanks @ingshtrom. Looks like the issue still exists
|
Signed-off-by: Alex Hokanson <[email protected]>
|
Oops! I fixed this, and then noticed that the header and side-bar changes color (black navbar, and darker sidebar) at the lowest resolutions. I fixed that, but maybe it was purposeful. Please let me know if it was and I can roll that back. |
|
Thank you @ingshtrom. It looks fine to me. @StefanScherer Do you mind taking another look when you get a chance? Thanks. |
| @@ -117,16 +118,10 @@ | |||
| .header { | |||
| height: 100px; | |||
| } | |||
| .nav-secondary-tabs, | |||
| .nav-secondary { | |||
| background-color: $black; | |||
There was a problem hiding this comment.
Looks good so far, only thing I see is that on mobile the top bar is blue in light mode, but when I rotate my mobile to landscape it turns black.
Previously on mobile it always was black. I think this change here was for black -> blue.
I like the blue background better in light mode.
But we should also fix it for landscape mode further down line 234 ff.
There was a problem hiding this comment.
Right, what I noticed was that on mobile the navbar (top bar) was black so I was trying to make it consistent with non-mobile views. I will change this for landscape mode as well. Nice find!
|
Oh, man.... I also noticed the search input changes based on the size of the screen... I'll fix that too. https://drive.google.com/file/d/15je_vt8KA1k_2t2XUhhDtzCAHKdDXXNT/view?usp=sharing |
Signed-off-by: Alex Hokanson <[email protected]>
Signed-off-by: Alex Hokanson <[email protected]>
|
PTAL. I think I got it this time. Mobile portrait and landscape are looking good. Just making a desktop screen smaller is looking good. |
Proposed changes
This fixes #11366 by adding the background color for the correct class name. It
seems that
.sidebar-homeused to be used a lot, but I couldn't find its usageanywhere (when loading up the docs app), so I stuck to using
.sidebar, whichseemed to work 😄
Unreleased project version (optional)
Related issues (optional)
Fixes #11366