-
Notifications
You must be signed in to change notification settings - Fork 7.8k
ENGDOCS-1020 #15857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENGDOCS-1020 #15857
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Looks good! Here are the changes I noticed:
All of these seem like solid improvements to me. Let me know if I missed anything, though!
Reference(I found myself wondering what had changed in the recent iterations. Hope this is useful to you too!)
|
This is a nit that's possibly out of scope! ... When a tip box immediately follows a heading, there doesn't seem to be enough vertical space. For example, in this plugin install section: |
Not blocking, but I do wonder whether it's possible to offer a bit more context on why a user would choose to install Compose standalone? For Scenario two, we do imply that you might want the plugin if you already have Docker Engine and CLI, and don't want to install DD for whatever reason. Is there some extra bit of info we can similarly offer for Scenario three? (I apologize that I myself don't actually know how to contextualize this! My vague understanding is that we don't much support this install route, but offer it nonetheless for legacy reasons? CCing @StefanScherer in case he might have more context.) |
Yes, installing compose v2 standalone is only for legacy reasons, maybe users have lots of scripts that use Looking at package managers that help installing docker-compose show at least some interest on Mac via homebrew, but on Windows I was never asked to update the docker-compose chocolatey package beyond v1. |
Thank you for the feedback @hyu and extra context @StefanScherer. Re: adding extra context for scenario three. Re: tip box formatting |
This seems like the right approach!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No new content added, just moving it around