-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Rename default branch #15915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename default branch #15915
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@crazy-max I think I caught all relevant occurrences of |
Thanks @dvdksn. I believe we should also update the workflows in GH Actions. For ex: https://github.com/docker/docs/blob/master/.github/workflows/build.yml |
I missed the most obvious one!!! 🙈 |
@dvdksn As discussed I will open a PR to update subject claim in terraform module to deploy to AWS. Also I think we have to update the prod branch on Netlify: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for subject claim to be changed and branch being renamed before merging.
@crazy-max @dvdksn Wondering how the branch rename would affect the existing PRs that still point to the 'master' branch? |
Will be changed automatically. |
Proposed changes
This PR updates the name of the default branch (from
master
tomain
) in files of the docs repository.In addition to this PR, three additional changes must take place:
website_docs_docker_com
Terraform moduleOnly when the above changes are completed should this branch be merged. We should coordinate the changes as such that this PR is the first to get merged after the changes are made.